Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On telegram, we always get video not found UI #283

Closed
jellegerbrandy opened this issue Mar 1, 2018 · 8 comments
Closed

On telegram, we always get video not found UI #283

jellegerbrandy opened this issue Mar 1, 2018 · 8 comments

Comments

@jellegerbrandy
Copy link
Contributor

jellegerbrandy commented Mar 1, 2018

reproduce by opening (say) a post in telegram and try to placy the vid

0e920ab5-66c4-4d07-92a7-742d53565f2d

@jellegerbrandy jellegerbrandy changed the title player is not playing inline on iphone player is not playing on iphone, but only on telegram Mar 1, 2018
@jellegerbrandy jellegerbrandy changed the title player is not playing on iphone, but only on telegram on telegram, the player is not playing on iphone Mar 2, 2018
@bent0b0x
Copy link
Contributor

bent0b0x commented Apr 8, 2018

FYI I just tested on staging, and I think #437 may have resolved the original issue. However, we are not always getting the "Ooooops, video not found!" message on telegram

@bent0b0x
Copy link
Contributor

bent0b0x commented Apr 8, 2018

I would love some ideas as to how to debug this, as I really have no idea 😄

@bent0b0x bent0b0x changed the title on telegram, the player is not playing on iphone Telegram/FB, the player is not playing Apr 8, 2018
@bent0b0x bent0b0x self-assigned this Apr 8, 2018
@bent0b0x
Copy link
Contributor

bent0b0x commented Apr 8, 2018

I believe this is related to our opengraph implementation. I do not think it is fully working, as can be seen by testing on https://developers.facebook.com/tools/debug/sharing/

cc @geckoslair

@felipegaucho
Copy link
Contributor

I believe this is solved:

screen shot 2018-04-13 at 3 42 55 am

screen shot 2018-04-13 at 3 43 03 am

Lacking maybe only the play/initial state :) #449

@bent0b0x
Copy link
Contributor

Telegram still does not work. I’m going to reopen and change the title

@bent0b0x bent0b0x reopened this Apr 13, 2018
@bent0b0x bent0b0x changed the title Telegram/FB, the player is not playing On telegram, we always get video not found UI Apr 13, 2018
@geckoslair
Copy link
Member

@bent0b0x please let me know if i can help you =)

@bent0b0x
Copy link
Contributor

I think I know the fix for this, might have to push it to staging to test but working on it

@bent0b0x
Copy link
Contributor

Okay, this is resolved on production (with no action). The reason it looked broken is because staging and local does not work.

These lines are the reason. I don't know if this is a big deal; essentially we have hard-coded portal.paratii-video in some places, which will make staging embeds not work. This is not great for testing. I have opened up this issue so that we can revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants