Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author name to search results #561

Closed
bent0b0x opened this issue May 8, 2018 · 8 comments
Closed

Add author name to search results #561

bent0b0x opened this issue May 8, 2018 · 8 comments

Comments

@bent0b0x
Copy link
Contributor

bent0b0x commented May 8, 2018

When #530 is resolved, we should display the author name for videos in the search results:

image

Link to design

This is replacing #539

@bent0b0x
Copy link
Contributor Author

I think we've been thinking about the video authorname incorrectly actually. We should not attach an explicit author field to the videos at upload or publish time, because I'm sure we will enable people to change their usernames and then we'd have stale author fields.

@geckoslair, can we make it so that the db will not only include owner address in video query results, but also the db will fetch and attach ownerUsername (or author) to resulting JSON as well? I think we should do this on all calls to /videos, whether it is for search or just fetching one video.

Let me know your thoughts!

@jellegerbrandy
Copy link
Contributor

We'd already decided to remove the author field from all the forms, and I think we've done that (looking at staging).

This basically means that new videos will not get a separate "author" field (they'll just get the name fo the uploader - note that this is not perfect either and we may want to change that again in the future)

I'm not sure what to do with the "old" author names in the existing videos. One of 3 options:

  1. keep the legacy, and use a scheme such as ben proposes above
  2. remove the authro field from everything, and just loose the existing author names
  3. remove the author field from everything, but create some user accounts in which we copy the author field (if we have collisions, we will just choose one).

@jellegerbrandy
Copy link
Contributor

personally, I'd be for 2, at most 3.

@jellegerbrandy
Copy link
Contributor

jellegerbrandy commented May 19, 2018

This issue about how to represent video-author in the db is relevant: Paratii-Video/paratii-db#134

@jellegerbrandy
Copy link
Contributor

if I'm not mistaken, paratii-db now returns an author of the video. We can close this issue if we just shwo that author field in the search results. @bent0b0x or @eliawk , when you have time, would be nice to close this before tomorrow's call...

1 similar comment
@jellegerbrandy
Copy link
Contributor

if I'm not mistaken, paratii-db now returns an author of the video. We can close this issue if we just shwo that author field in the search results. @bent0b0x or @eliawk , when you have time, would be nice to close this before tomorrow's call...

@geckoslair
Copy link
Member

closed at paratii-db side

@bent0b0x
Copy link
Contributor Author

bent0b0x commented Jun 1, 2018

Working on this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants