Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wait indefinitely for video fetch on server #703

Closed
bent0b0x opened this issue Jun 13, 2018 · 0 comments
Closed

Do not wait indefinitely for video fetch on server #703

bent0b0x opened this issue Jun 13, 2018 · 0 comments

Comments

@bent0b0x
Copy link
Contributor

If we try to access the play/:video_id route, the server will hang indefinitely waiting for the promise to fetch this video resolve. See this line. We cannot do this as it is a horrible UX. We need to instead resolve quickly, knowing the video id doesn't exist/could not be fetched, and then show an error page or redirect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants