Skip to content
This repository was archived by the owner on Mar 8, 2024. It is now read-only.

refactor: receipts -> payment proofs #343

Merged
merged 0 commits into from
May 13, 2020
Merged

refactor: receipts -> payment proofs #343

merged 0 commits into from
May 13, 2020

Conversation

0xASK
Copy link
Collaborator

@0xASK 0xASK commented May 11, 2020

High Level Overview of Change

Renaming receipts to payment proofs in accordance with the change log.

Context of Change

We shifted the protocol to use payment proofs instead of receipts because receipts was a misleading term.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Before / After

  • docs are updated to say payment proof instead of receipt
  • vars are renamed
  • path is changed from receipt to payment-proofs

Test Plan

All unit tests continue to pass.

Sorry, something went wrong.

@0xASK 0xASK requested review from dino-rodriguez and 0xCLARITY May 11, 2020 18:39
0xCLARITY
0xCLARITY approved these changes May 12, 2020
View reviewed changes
Copy link
Collaborator

@0xCLARITY 0xCLARITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Glad we're knocking out some of our Changelog decisions.

dino-rodriguez
dino-rodriguez reviewed May 12, 2020
View reviewed changes
Copy link
Member

@dino-rodriguez dino-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Looks like CI is failing though.

@0xASK 0xASK merged this pull request into master May 13, 2020
@0xASK 0xASK deleted the ak-receipts-to-payment-proofs branch May 13, 2020 21:38
dino-rodriguez pushed a commit that referenced this pull request Jun 17, 2020
@0xCLARITY
refactor: receipts -> payment proofs (#343)
834d812 
* refactor: receipts -> payment proofs

* fix: lint

Co-authored-by: Hans Bergren <hansbergren@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dino-rodriguez dino-rodriguez

@0xCLARITY 0xCLARITY

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0xASK @dino-rodriguez @0xCLARITY