-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controlled.wires
does not contain work wires
#5728
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many other places that use active_wires
, see failing tests. I would do a search of active_wires
across the entire repo and make substitutions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5728 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 416 416
Lines 38689 38393 -296
==========================================
- Hits 38565 38268 -297
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎸
Context:
Controlled.wires
containedwork_wires
that are typically used for the decomposition. This was inconsistent with the general usage of the attributes. The expected wires behaviour was in theactive_wires
.Description of the Change:
active_wires
was renamed towires
, andwork_wires
has been removed from the returned wires forself.wires
Benefits:
[55898]