Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlled.wires does not contain work wires #5728

Merged
merged 6 commits into from
May 28, 2024

Conversation

Shiro-Raven
Copy link
Contributor

Context:
Controlled.wires contained work_wires that are typically used for the decomposition. This was inconsistent with the general usage of the attributes. The expected wires behaviour was in the active_wires.

Description of the Change:
active_wires was renamed to wires, and work_wires has been removed from the returned wires for self.wires

Benefits:

  • More consistent behaviour of wiring attributes

[55898]

@Shiro-Raven Shiro-Raven requested review from albi3ro and astralcai May 22, 2024 21:15
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@astralcai astralcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many other places that use active_wires, see failing tests. I would do a search of active_wires across the entire repo and make substitutions.

@Shiro-Raven Shiro-Raven requested a review from astralcai May 24, 2024 18:44
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (c285b87) to head (3071824).
Report is 262 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5728      +/-   ##
==========================================
- Coverage   99.67%   99.67%   -0.01%     
==========================================
  Files         416      416              
  Lines       38689    38393     -296     
==========================================
- Hits        38565    38268     -297     
- Misses        124      125       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
Copy link
Contributor

@astralcai astralcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎸

@Shiro-Raven Shiro-Raven requested a review from mudit2812 May 28, 2024 17:55
@Shiro-Raven Shiro-Raven merged commit 5b192e6 into master May 28, 2024
40 checks passed
@Shiro-Raven Shiro-Raven deleted the ad/controlled-has-work-wires branch May 28, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants