Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to terminate ros_main node cleanly. #105

Closed
ValerioMagnago opened this issue Feb 20, 2023 · 2 comments
Closed

Impossible to terminate ros_main node cleanly. #105

ValerioMagnago opened this issue Feb 20, 2023 · 2 comments

Comments

@ValerioMagnago
Copy link
Contributor

It is not possible to kill the node cleanly.
Calling rosnode kill brings the driver into a deadlock situation and it is not possible to kill cleanly the node.

image

@hsd-dev
Copy link
Contributor

hsd-dev commented Feb 20, 2023

Yes this is a known issue, but I have ignored it so far since it was not a blocking factor for the current users. Have you been able to debug the problem?

@ValerioMagnago
Copy link
Contributor Author

ValerioMagnago commented Feb 20, 2023

No, I didn't analyze the problem, but looking at the code this line here seems suspicious.

net_cv_->wait(net_lock, [&net_fail] { return net_fail; });

If my understanding is correct, here we just wait for a network failure but we do not react to a node termination.

Side note. I see you are using a ros::AsyncSpinner and you set the number of threads as the number of processor core (https://docs.ros.org/en/noetic/api/roscpp/html/classros_1_1AsyncSpinner.html#aa5b9b685b7eebebf18ed42697e209897) why?

ValerioMagnago added a commit to ValerioMagnago/pf_lidar_ros_driver that referenced this issue Feb 21, 2023
ValerioMagnago added a commit to ValerioMagnago/pf_lidar_ros_driver that referenced this issue Feb 21, 2023
ValerioMagnago added a commit to ValerioMagnago/pf_lidar_ros_driver that referenced this issue Feb 21, 2023
@ptruka ptruka closed this as completed in 6c1820f Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants