Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shapes display by re-enabling lightning #1211

Merged
merged 2 commits into from
Apr 16, 2015
Merged

Improve shapes display by re-enabling lightning #1211

merged 2 commits into from
Apr 16, 2015

Conversation

VictorLamoine
Copy link
Contributor

Before

before

After

after

Test project

At your fingertips

@jspricke
Copy link
Member

Thanks Victor, it looks clearly like an improvement. Only, the lightning seems to be specifically disabled here: d72d9b8 with a commit comment about wireframes. Can we disable it for wireframes maybe?

@VictorLamoine
Copy link
Contributor Author

It's not a problem to enable lightning for shapes displayed as wireframe, I have just added
viewer.setRepresentationToWireframeForAllActors(); before launching the viewer, here are the results:

Before

before_wireframe

After

after_wireframe

@jspricke
Copy link
Member

You have to turn it around to see the the difference ;) (I've tried it over here).

@VictorLamoine
Copy link
Contributor Author

I don't understand what you want to point; the wireframe lines are shaded.
Is there anything wrong with this?

@jspricke
Copy link
Member

Run your test_shapes, press w turn model:
screenshot-1429188676

screenshot-1429188689

@VictorLamoine
Copy link
Contributor Author

It happens because of the black background;
green_bg

I added a new commit that changes the setRepresentationTo*ForAllActors () and the key s / w behavior.

Lighting for wireframe models is disabled
Lighting for surface models is enabled

@jspricke
Copy link
Member

jspricke commented Apr 16, 2015 via email

taketwo added a commit that referenced this pull request Apr 16, 2015
Improve shapes display by re-enabling lightning
@taketwo taketwo merged commit ae08f07 into PointCloudLibrary:master Apr 16, 2015
@VictorLamoine VictorLamoine deleted the vtk_shapes branch April 16, 2015 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants