-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests CMake and Travis refactoring #1786
Merged
jspricke
merged 2 commits into
PointCloudLibrary:master
from
SergioRAgostinho:tests_refactor
May 30, 2017
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,27 @@ | ||
| PCL_ADD_TEST(test_2d test_2d FILES test_2d.cpp | ||
| LINK_WITH pcl_io pcl_gtest | ||
| ARGUMENTS "${PCL_SOURCE_DIR}/test/2d/lena.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/gauss_smooth.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/erosion.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/dilation.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/opening.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/closing.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/erosion_binary.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/dilation_binary.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/opening_binary.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/closing_binary.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/canny.pcd") | ||
| set(SUBSYS_NAME tests_2d) | ||
| set(SUBSYS_DESC "Point cloud library 2d module unit tests") | ||
| PCL_SET_TEST_DEPENDENCIES(SUBSYS_DEPS 2d) | ||
|
|
||
|
|
||
| set(OPT_DEPS) | ||
|
|
||
| set(DEFAULT ON) | ||
| set(build TRUE) | ||
| PCL_SUBSYS_OPTION(build "${SUBSYS_NAME}" "${SUBSYS_DESC}" ${DEFAULT} "${REASON}") | ||
| PCL_SUBSYS_DEPEND(build "${SUBSYS_NAME}" DEPS ${SUBSYS_DEPS} OPT_DEPS ${OPT_DEPS}) | ||
|
|
||
| if(build) | ||
| PCL_ADD_TEST(test_2d test_2d FILES test_2d.cpp | ||
| LINK_WITH pcl_io pcl_gtest | ||
| ARGUMENTS "${PCL_SOURCE_DIR}/test/2d/lena.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/gauss_smooth.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/erosion.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/dilation.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/opening.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/closing.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/erosion_binary.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/dilation_binary.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/opening_binary.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/closing_binary.pcd" | ||
| "${PCL_SOURCE_DIR}/test/2d/canny.pcd") | ||
| endif(build) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,41 @@ | ||
| # Args: name, executable_name | ||
| PCL_ADD_TEST(common_test_wrappers test_wrappers FILES test_wrappers.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_test_macros test_macros FILES test_macros.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_vector_average test_vector_average FILES test_vector_average.cpp LINK_WITH pcl_gtest) | ||
| PCL_ADD_TEST(common_common test_common FILES test_common.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_geometry test_geometry FILES test_geometry.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_copy_point test_copy_point FILES test_copy_point.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_centroid test_centroid FILES test_centroid.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_int test_plane_intersection FILES test_plane_intersection.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_pca test_pca FILES test_pca.cpp LINK_WITH pcl_gtest pcl_common) | ||
| #PCL_ADD_TEST(common_spring test_spring FILES test_spring.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_gaussian test_gaussian FILES test_gaussian.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_operators test_operators FILES test_operators.cpp LINK_WITH pcl_gtest pcl_common) | ||
| #PCL_ADD_TEST(common_convolution test_convolution FILES test_convolution.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_eigen test_eigen FILES test_eigen.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_intensity test_intensity FILES test_intensity.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_generator test_generator FILES test_generator.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_io test_common_io FILES test_io.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_copy_make_borders test_copy_make_borders FILES test_copy_make_borders.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_bearing_angle_image test_bearing_angle_image FILES test_bearing_angle_image.cpp LINK_WITH pcl_gtest pcl_common) | ||
| set(SUBSYS_NAME tests_common) | ||
| set(SUBSYS_DESC "Point cloud library common module unit tests") | ||
| PCL_SET_TEST_DEPENDENCIES(SUBSYS_DEPS common) | ||
| set(OPT_DEPS io features search kdtree octree) | ||
|
|
||
| PCL_ADD_TEST(common_point_type_conversion test_common_point_type_conversion FILES test_point_type_conversion.cpp LINK_WITH pcl_gtest pcl_common) | ||
| set(DEFAULT ON) | ||
| set(build TRUE) | ||
| PCL_SUBSYS_OPTION(build "${SUBSYS_NAME}" "${SUBSYS_DESC}" ${DEFAULT} "${REASON}") | ||
| PCL_SUBSYS_DEPEND(build "${SUBSYS_NAME}" DEPS ${SUBSYS_DEPS} OPT_DEPS ${OPT_DEPS}) | ||
|
|
||
| if (build) | ||
| # Args: name, executable_name | ||
| PCL_ADD_TEST(common_test_wrappers test_wrappers FILES test_wrappers.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_test_macros test_macros FILES test_macros.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_vector_average test_vector_average FILES test_vector_average.cpp LINK_WITH pcl_gtest) | ||
| PCL_ADD_TEST(common_common test_common FILES test_common.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_geometry test_geometry FILES test_geometry.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_copy_point test_copy_point FILES test_copy_point.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_centroid test_centroid FILES test_centroid.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_int test_plane_intersection FILES test_plane_intersection.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_pca test_pca FILES test_pca.cpp LINK_WITH pcl_gtest pcl_common) | ||
| #PCL_ADD_TEST(common_spring test_spring FILES test_spring.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_gaussian test_gaussian FILES test_gaussian.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_operators test_operators FILES test_operators.cpp LINK_WITH pcl_gtest pcl_common) | ||
| #PCL_ADD_TEST(common_convolution test_convolution FILES test_convolution.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_eigen test_eigen FILES test_eigen.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_intensity test_intensity FILES test_intensity.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_generator test_generator FILES test_generator.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_io test_common_io FILES test_io.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_copy_make_borders test_copy_make_borders FILES test_copy_make_borders.cpp LINK_WITH pcl_gtest pcl_common) | ||
| PCL_ADD_TEST(common_bearing_angle_image test_bearing_angle_image FILES test_bearing_angle_image.cpp LINK_WITH pcl_gtest pcl_common) | ||
|
|
||
| PCL_ADD_TEST(common_point_type_conversion test_common_point_type_conversion FILES test_point_type_conversion.cpp LINK_WITH pcl_gtest pcl_common) | ||
|
|
||
| if (BUILD_io AND BUILD_features) | ||
| PCL_ADD_TEST(a_transforms_test test_transforms | ||
| FILES test_transforms.cpp | ||
| LINK_WITH pcl_gtest pcl_io | ||
| ARGUMENTS "${PCL_SOURCE_DIR}/test/bun0.pcd") | ||
| endif (BUILD_io AND BUILD_features) | ||
| endif (build) |
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This brings us an ancient version of Doxygen from 2011 (1.7.6 to be precise). Apart from gazillion bug fixes, one useful feature that is missing there is Markdown support. Back in the day I even made a PR (#526) to get a newer version. I'm not sure how much of PCL docstrings are actually written with Markdown, but the fact that I made that request suggests that there are at least some.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks exactly like the solution we need. Doxygen packages backported for Precise. It will bump the version to 1.8.8 which already has markdown support.