Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reentrant interface of qhull (2015+) when available #2154

Closed

Conversation

woodychow
Copy link
Contributor

New code should be written with libqhull_r. Existing users of libqhull should consider converting to libqhull_r. Although libqhull will be supported indefinitely, improvements may not be implemented. Reentrant qhull is 1-2% slower than non-reentrant qhull.
http://www.qhull.org/html/qh-code.htm

@taketwo
Copy link
Member

taketwo commented Dec 15, 2017

Duplicate of #1565?

@SergioRAgostinho SergioRAgostinho added duplicate changelog: enhancement Meta-information for changelog generation labels Dec 15, 2017
@SergioRAgostinho
Copy link
Member

Definitely. @woodychow it would be great if you then could also review the current undergoing work at #1565 and contribute with your inputs there.

In the meantime I'll be closing this as a duplicate.

@woodychow
Copy link
Contributor Author

Great. I did not know there is already a merge request. I did not have time to investigate the C++ interface; that's why I just quickly changed the code to use the re-entrant C interface for my stuff. I will take a look at #1565. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: enhancement Meta-information for changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants