-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize some CMake macros (Increases minimum required CMake version to 3.5) #3044
Modernize some CMake macros (Increases minimum required CMake version to 3.5) #3044
Conversation
6ba659d
to
75a4342
Compare
…ptional parameter BUNDLE
75a4342
to
df5b630
Compare
Don't forget to update these documentations files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When all is reviewed, I propose to squash the "fixup" commit df5b630 onto the original commit which generated that particular line.
How you want to squash with master? The fixup fixes something which is already merged into master. |
Ignore what I said then 😅 I reviewed the PR per commit and thought it was something added on some previous commit. |
Heads up: I'm unable to successfully configure CMake on my OSX environment after this PR. Need to figure out what is different between me and the CI. Here's a really shortened version of the error log
It's being very clear about the reason. I'll dig into it to better understand what changed. |
This is a preparation for another change, which I didn't got ready today. But I think it's already enough for a PR.
//Edit: Typical error source: Using to modern CMake commands. PCL now requires CMake 3.5, because
cmake_parse_arguments
was new in CMake core with CMake 3.5. Wanted already to usePARSE_ARGV N
, but this was introduced in 3.7, so had to use old way.//Edit2: We could keep CMake 3.1 compatibility by calling
include(CMakeParseArguments)
before. As far as I see we usedcmake_parse_arguments
already before this changes, but we didn't included module, so CMake script was already broken for 3.4 and below xD