Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine PCL_SUBSUBSYS_DEPEND with PCL_SUBSYS_DEPEND #5387

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Combine PCL_SUBSUBSYS_DEPEND with PCL_SUBSYS_DEPEND #5387

merged 1 commit into from
Aug 19, 2022

Conversation

SunBlack
Copy link
Contributor

Fixes #5379

Note: Added NAME as parameter as I think named parameter increases the readability.

@SunBlack SunBlack force-pushed the combine_PCL_SUBSYS_DEPEND branch 2 times, most recently from df01295 to 1a1ff1c Compare August 18, 2022 11:36
@SunBlack SunBlack force-pushed the combine_PCL_SUBSYS_DEPEND branch from 1a1ff1c to ca53f26 Compare August 18, 2022 11:42
@larshg
Copy link
Contributor

larshg commented Aug 18, 2022

Can you do same exercise for PCL_(SUB)SUBSYS_OPTION also? 😃

@SunBlack
Copy link
Contributor Author

Can you do same exercise for PCL_(SUB)SUBSYS_OPTION also? 😃

Not in this PR, was not even sure if I should make the changes related to NAME here or not, as I prefer small PRs ;-). But yeah, the CMake code here has a lot of thing which should refactored.

mvieth
mvieth approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvieth mvieth added changelog: enhancement Meta-information for changelog generation module: cmake labels Aug 19, 2022
@mvieth mvieth merged commit 44fea0a into PointCloudLibrary:master Aug 19, 2022
@SunBlack SunBlack deleted the combine_PCL_SUBSYS_DEPEND branch August 19, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshg larshg larshg approved these changes

@mvieth mvieth mvieth approved these changes

Assignees
No one assigned
Labels
changelog: enhancement Meta-information for changelog generation module: cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cmake] Combine PCL_SUBSUBSYS_DEPEND with PCL_SUBSYS_DEPEND
3 participants
@SunBlack @larshg @mvieth