refactor: use sigs.k8s.io/yaml and json tags #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkubaczyk
approved these changes
Jul 21, 2022
mkubaczyk
added a commit
that referenced
this pull request
Aug 18, 2023
refactor: use sigs.k8s.io/yaml and json tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since invopop/jsonschema#23 was merged
jsonschemano longer supportsyamltags, and we've updated to that version in #682, we'd need to add addition json tags to keep using go-yaml, we can avoid duplicate YAML and JSON tags by usingsigs.k8s.io/yamlthat first converts YAML to JSON using go-yaml and then usesjson.Marshalandjson.Unmarshalto convert to or from the struct. This means that it effectively reuses the JSON struct tags as well as the custom JSON methodsMarshalJSONandUnmarshalJSONunlike go-yaml.