-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.16.5 support #518
1.16.5 support #518
Conversation
What do you mean by you didn’t? |
Flying-squid seems to send this packet if there is more than one block update at a tick (for example, an explosion), I didn't found a way to satisfies this condition just by breaking blocks in-game and, I was wondering if there is a /explosion command or a /fill command or any other way to make more than one update per tick in-game. |
How far along is this? |
@GroobleDierne Hi, can I remake this PR if you don't want to finish this? |
Feel free to do so, I won't have the time to finish it before long. |
anyone feel like finishing this? |
|
I don't have time to finish it but if someone does I can pull their changes into this branch |
I understand that, but I need to know what changes need to be made until 1.16.5 works |
The multi_blocks_change packet still needs to be tested, in theory I updated it but at the time that packet was never used by flying-squid so I wasn't able to test it. |
too old, feel free to redo |
Close #447
Still work in progress.
I have some questions: here https://github.com/PrismarineJS/flying-squid/blob/master/src/lib/version.js#L2
the supported versions are specified with their minor version but here https://github.com/PrismarineJS/flying-squid/blob/master/src/index.js#L46 the minor version is ignored. So I was wondering if I should change it to check also the minor version, so only the latest minor version will be supported for each Minecraft major version. That would simplify development (especially for 1.16 where there are a lot of differences between 1.16.1 and 1.16.2 and superior) but it will reduce the number of available versions.
Also, I didn't found a way to trigger a multi_block_change packet (here https://github.com/PrismarineJS/flying-squid/blob/master/src/lib/plugins/blockUpdates.js#L153)