Remove old version checks

[malberts]

Summary by CodeRabbit

• Refactor
  • Simplified conditional configurations to consistently deliver content features and external link displays across all supported versions.
• Tests
  • Updated test cases to verify the unified behavior without version-dependent conditions.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes remove conditional logic based on the MediaWiki version across multiple components. In the hooks and unit tests, version checks have been eliminated to ensure that feature arrays, external link styling, and user group expectations are handled uniformly regardless of the MediaWiki version. No modifications were made to exported or public entities.

Changes

File(s)	Change Summary
src/Hooks/ResourceLoaderRegisterModules.php, tests/.../ResourceLoaderRegisterModulesTest.php	Removed MW_VERSION-based conditionals that previously altered the feature arrays and the inclusion of 'content-links-external', ensuring consistent behavior regardless of version.
src/Hooks/SetupAfterCache.php	Removed the conditional block that added the external link icon styling based on configuration and MW_VERSION checks.
tests/.../MockupFactory.php	Removed MW_VERSION-based conditionals for setting expectations on the user's getEffectiveGroups method.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 578f2ef and 4788c5f.

📒 Files selected for processing (4)

• src/Hooks/ResourceLoaderRegisterModules.php (0 hunks)
• src/Hooks/SetupAfterCache.php (0 hunks)
• tests/phpunit/Unit/Hooks/ResourceLoaderRegisterModulesTest.php (1 hunks)
• tests/phpunit/Util/MockupFactory.php (0 hunks)

💤 Files with no reviewable changes (3)

• tests/phpunit/Util/MockupFactory.php
• src/Hooks/SetupAfterCache.php
• src/Hooks/ResourceLoaderRegisterModules.php

🔇 Additional comments (1)

tests/phpunit/Unit/Hooks/ResourceLoaderRegisterModulesTest.php (1)

114-114: LGTM! Successfully removed version check.

The unconditional addition of 'content-links-external' aligns with the PR objective of removing MediaWiki version checks, simplifying the test logic while maintaining its purpose of verifying external link icon functionality.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.