Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move demo pages to /public folder #4119

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Move demo pages to /public folder #4119

wants to merge 1 commit into from

Conversation

marlo-longley
Copy link
Member

@marlo-longley marlo-longley commented Feb 28, 2025

This removes the long URLs at __tests__/integration/mirador
This is possible because of the recent work to decouple the integration tests from these pages.
This also seems to fix some issues with HMR and reloading these pages using Vite's dev server; Vite prefers things to be in /public.
Now locally you would go to http://localhost:4444/collections.html, http://localhost:4444/index.html, etc.

This removes the long URLs at __tests__/integration/mirador
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (1fb2797) to head (b14e791).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4119   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files         323      323           
  Lines       16158    16158           
  Branches     2539     2541    +2     
=======================================
  Hits        15318    15318           
  Misses        835      835           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant