Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin txt description #5

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Plugin txt description #5

wants to merge 8 commits into from

Conversation

Pshy0
Copy link
Owner

@Pshy0 Pshy0 commented Aug 28, 2023

This implements the new about property in plugin.txt.

@Pshy0 Pshy0 added enhancement New feature or request awaiting game update This cannot be fixed until a future game version is available labels Aug 28, 2023
@Pshy0 Pshy0 self-assigned this Aug 28, 2023
@Pshy0 Pshy0 force-pushed the main branch 2 times, most recently from 6f1f931 to 0cec6f8 Compare August 28, 2023 18:28
@TheGiraffe3
Copy link
Contributor

This could be merged now as the plugin.txt file has been in many releases.

@Pshy0
Copy link
Owner Author

Pshy0 commented Jan 29, 2025

This file has indeed been implemented for many releases now.

I not only delayed merging this because the old syntax is still supported while the new one was giving errors in older versions, but also because this feature was not allowing multiline abouts at the time (a regression). I do not know if this have since been fixed.

@TheGiraffe3
Copy link
Contributor

It has.

@Pshy0 Pshy0 added this to the endless-sky 0.10.12 milestone Jan 29, 2025
Pshy0 and others added 2 commits January 30, 2025 11:17
Co-authored-by: Loymdayddaud <145969603+TheGiraffe3@users.noreply.github.com>
@Pshy0 Pshy0 removed this from the endless-sky 0.10.12 milestone Jan 30, 2025
@Pshy0
Copy link
Owner Author

Pshy0 commented Jan 30, 2025

After testing, I confirm the multiline about feature in plugin.txt have still not been fixed.
This PR will be further delayed.

@Pshy0
Copy link
Owner Author

Pshy0 commented Jan 30, 2025

@Pshy0
Copy link
Owner Author

Pshy0 commented Jan 30, 2025

After investigating, multiline abouts are working like this:

about `Ruin The Fun (CHEAT PLUGIN)`
about `  A development / cheat plugin to explore and try out all content.`
about `  Access all ships and outfits, change your captain's name, choose the color swizzle of your ships, edit your relation with other governments, set your combat rank, hire a powerful escort, gift yourself pre-outfitted ships, give yourself money, and much more.`

However, documentation says that it's not supported, so I'll wait that either documentation gets fixed or this syntax gets implemented in a stable release.

@Pshy0 Pshy0 added this to the endless-sky 1.0 milestone Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting game update This cannot be fixed until a future game version is available enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants