-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added docs on debugging using breakpoints #4943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't use vs code so I didn't look at that part but I have some suggestions for the lldb/gdb content.
Also maybe you can use a tab switcher so people don't have to see both versions? I'm not sure if the pyo3 docs system has a way to have a clickable tab switch between the gdb and lldb instructions.
Co-authored-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>
@ngoldbaum For the tab switcher that will be nice but it will require adding the mdbook-tabs plugin, if you think it is the best option I am keen to do it, I just didn't want to add an extra dependency just for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, a useful collection of options!
I would be ok to add mdbook-tabs
, are you happy to do it as part of this PR?
import sys | ||
|
||
|
||
def update_launch_json(vscode_config_file_path=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 this is a pretty nice trick!
@davidhewitt yeah ofc ! More than happy to add it, I'll add it as part of the next commit |
The tab switcher looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, thank you!
@davidhewitt There seems to be some kind of problem on the CI pipeline on the merge, specifically with Python3.7, not sure about this issue, is this something you might know why its happening ? |
The 3.7 issues should not be blocking, I will fix those separately. Looks like we have some CI bitrot on both |
It think like the graalpy issue was caused by github flakiness (I'm getting some timeouts from github releases API this morning, I think that's the likely root cause). It looks like |
Makes sense thank you, I did check the Github status page and it looked like they had some issues today. |
@LifeLex, have you tested this on Windows? As far as I know, there is an issue with debug symbols when using |
@WSH032 I haven't because I don't have a windows machine at the moment, but I've tested it on both Linux and MacOS and I had no issues, if you are asking because of the CI issue it feels to me that that is related with something else |
No, this is not related to the CI issue. On Windows, debug symbols are in separate When using Until PyO3/maturin#2220 is merged, the best solution is to manually copy these I think it would be best to document this. |
@ngoldbaum, sure. I'm happy to contribute to |
Indeed, the There is probably some work due to improve the cache situation, I will try to write an issue about that... |
This PR aims to include docs on how to debug your rust code using breakpoints from python.
It also includes the setup for users of VSCode and an automatic setup for Jupyter Notebook users