RACE: Trim trailing \n when reading top scores. #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
v2 (optimized): --- src/race.c.orig 2025-02-16 18:01:44 UTC
+++ src/race.c
@@ -3541,10 +3541,9 @@ char* race_fgets(char *buf, int limit)
return NULL;
}
- string = buf;
- while (--limit > 0 && ((c = race_fgetc()) != -1))
+ for (string = buf; --limit > 0 && (c = race_fgetc()) != -1; string++)
{
- if ((*string++ = c) == '\n')
+ if ((*string = c) == '\n')
{
break;
} |
|
@VVD Here's where you create a new PR: https://github.com/QW-Group/ktx/pulls |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Feb 23, 2025
The bug that caused version 1.43 to be used when creating the port has been fixed - the patch has been added to the port. Upstream pool request: QW-Group/ktx#397 Changelogs: https://github.com/QW-Group/ktx/releases/tag/v1.44 https://github.com/QW-Group/ktx/releases/tag/1.45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced back in 2011 via 9fc1a31 but hidden thanks to strlcpy incorrectly using source buffer length (and risking buffer overflow). After fe38404 strlcpy was invoked with destination buffer length, and source buffer was copied up until NUL-termination and thus incorrectly included the \n.
Found by @VVD, fixes #388