-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'ignore-trailing-jobs' as optional flag #2759
Conversation
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems useful.
I don't think we want ignoring trailing jobs to be the default, though. Most users of nb-tester do want the safer behavior of canceling trailing jobs. It would be surprising to need to specify an arg to do the safe thing. This would be a gotcha for our local users of nb-tester
in this repository.
What do you think of renaming --cancel-trailing-jobs
to instead be --ignore-trailing-jobs
? So, we keep the default behavior the same as the status quo.
5bf2519
to
b5648cb
Compare
Seems reasonable to me! I rewrote the functionality to work as you described. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making that change!
PR title and description need updates, please |
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to let @frankharkins review and merge, but lgtm :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
nb-tester by default uses QiskitRuntimeService to cancel trailing jobs. This assumes that jobs are run using that same configuration, as opposed to being passed in via a patch. For notebooks run with fake backends, this should not be a requirement. The flag '--ignore-trailing-jobs' allows users of nb-tester to skip the step to cancel trailing jobs.