-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize numpy arrays with object types #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with the background on how encoding/deocing works here but based on what I read in the referenced issue and what I see in this PR it looks good :). Guess a secondary reviewer helps to gain more confidence.
@rathishcholarajan though it looks good to me: can you take a quick look if we can integrate it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kt474 Looks good. Could you update cloud-production URL to https://cloud.ibm.com in your fork to get rid of these errors https://github.com/kt474/qiskit-ibm-runtime/runs/5094722869?check_suite_focus=true#step:5:1029 and we can see if all integration tests pass before merging this?
@kt474 the integration test jobs of the CI runs on your fork are still failing due to configuration issues Can you check again? Feel free to reach out if you need help. More details are also available at https://github.com/Qiskit/qiskit-ibm-runtime/blob/main/CONTRIBUTING.md#configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kt474 Could you please resolve merge conflicts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pull Request Test Coverage Report for Build 1847984819
💛 - Coveralls |
@kt474 Could you please backport this as well to qiskit-ibmq-provider? |
Summary
Details and comments
Fixes Qiskit/qiskit-ibm-provider#74