Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize numpy arrays with object types #121

Merged
merged 11 commits into from
Feb 15, 2022

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jan 24, 2022

Summary

Details and comments

Fixes Qiskit/qiskit-ibm-provider#74

Copy link
Collaborator

@daka1510 daka1510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with the background on how encoding/deocing works here but based on what I read in the referenced issue and what I see in this PR it looks good :). Guess a secondary reviewer helps to gain more confidence.

@daka1510
Copy link
Collaborator

daka1510 commented Feb 7, 2022

@rathishcholarajan though it looks good to me: can you take a quick look if we can integrate it?

Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kt474 Looks good. Could you update cloud-production URL to https://cloud.ibm.com in your fork to get rid of these errors https://github.com/kt474/qiskit-ibm-runtime/runs/5094722869?check_suite_focus=true#step:5:1029 and we can see if all integration tests pass before merging this?

@daka1510
Copy link
Collaborator

daka1510 commented Feb 11, 2022

@kt474 the integration test jobs of the CI runs on your fork are still failing due to configuration issues
https://github.com/kt474/qiskit-ibm-runtime/actions/runs/1819857623

Can you check again? Feel free to reach out if you need help. More details are also available at https://github.com/Qiskit/qiskit-ibm-runtime/blob/main/CONTRIBUTING.md#configuration

Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kt474 Could you please resolve merge conflicts?

Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rathishcholarajan rathishcholarajan merged commit adfd6f2 into Qiskit:main Feb 15, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1847984819

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 189 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-5.3%) to 58.078%

Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/accounts/account.py 1 93.02%
qiskit_ibm_runtime/ibm_backend.py 1 60.0%
qiskit_ibm_runtime/runtime_program.py 1 88.68%
qiskit_ibm_runtime/api/auth.py 2 74.19%
qiskit_ibm_runtime/utils/backend_decoder.py 2 47.54%
qiskit_ibm_runtime/api/clients/base.py 4 88.03%
qiskit_ibm_runtime/utils/converters.py 6 18.97%
qiskit_ibm_runtime/api/rest/program_job.py 9 60.87%
qiskit_ibm_runtime/api/rest/cloud_backend.py 11 37.5%
qiskit_ibm_runtime/api/session.py 11 70.54%
Totals Coverage Status
Change from base Build 1846800755: -5.3%
Covered Lines: 2013
Relevant Lines: 3466

💛 - Coveralls

@kt474 kt474 deleted the numpy-object-encoder branch February 15, 2022 17:04
@rathishcholarajan
Copy link
Member

@kt474 Could you please backport this as well to qiskit-ibmq-provider?

@rathishcholarajan rathishcholarajan added the backport potential The bug might be minimal and/or important enough to be port to stable label Feb 18, 2022
@rathishcholarajan rathishcholarajan added the Changelog: Bugfix Include in the Fixed section of the changelog label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport potential The bug might be minimal and/or important enough to be port to stable Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running vqe runtime program with aux operator fails with serialization error
4 participants