Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom programs followup #1289

Merged
merged 12 commits into from
May 9, 2024
Merged

Custom programs followup #1289

merged 12 commits into from
May 9, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Dec 21, 2023

Summary

Details and comments

Fixes #1238

@kt474 kt474 added the Changelog: Deprecation Include in Deprecated section of changelog label Dec 21, 2023
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@coveralls
Copy link

coveralls commented Dec 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 9011124065

Details

  • 11 of 14 (78.57%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 83.479%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/base_runtime_job.py 4 5 80.0%
qiskit_ibm_runtime/qiskit_runtime_service.py 3 4 75.0%
qiskit_ibm_runtime/session.py 3 4 75.0%
Totals Coverage Status
Change from base Build 9011120990: -0.02%
Covered Lines: 6291
Relevant Lines: 7536
💛 - Coveralls

@kt474 kt474 marked this pull request as ready for review February 26, 2024 19:10
@kt474 kt474 requested a review from jyu00 February 26, 2024 19:10
@kt474 kt474 requested a review from ptristan3 April 25, 2024 19:20
@kt474 kt474 merged commit b2d0453 into Qiskit:main May 9, 2024
20 checks passed
@kt474 kt474 deleted the custom-program-followup branch May 9, 2024 02:17
ptristan3
ptristan3 reviewed May 9, 2024
View reviewed changes
Copy link
Collaborator

@ptristan3 ptristan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptristan3 ptristan3 ptristan3 left review comments

@jyu00 jyu00 Awaiting requested review from jyu00

Assignees
No one assigned
Labels
Changelog: Deprecation Include in Deprecated section of changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Follow up work for custom program removal
3 participants
@kt474 @coveralls @ptristan3