Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow new job status' in RuntimeJobV2 #1494

Merged
merged 9 commits into from
Apr 2, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Mar 7, 2024

Summary

Details and comments

Fixes #1476

@kt474 kt474 changed the title Update v2 job status handling Allow new job status' in RuntimeJobV2 Mar 7, 2024
@coveralls
Copy link

coveralls commented Mar 8, 2024

Pull Request Test Coverage Report for Build 8527581539

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 8 (12.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 83.648%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/runtime_job_v2.py 1 8 12.5%
Totals Coverage Status
Change from base Build 8515191737: -0.03%
Covered Lines: 6210
Relevant Lines: 7424

💛 - Coveralls

@kt474 kt474 requested a review from jyu00 March 11, 2024 15:18
@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label Mar 18, 2024
@kt474 kt474 requested a review from ptristan3 April 1, 2024 19:14
Copy link
Collaborator

@ptristan3 ptristan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor comment/suggestion

@kt474 kt474 merged commit 8967122 into Qiskit:main Apr 2, 2024
18 checks passed
@kt474 kt474 deleted the update-job-status-mapping branch April 2, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New RuntimeJobV2 doesn't allow new statuses
3 participants