Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required pydantic version in setup #1759

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jun 19, 2024

Summary

Related to #1577 - users that already have pydantic installed in the their environments may run into incompatibility issues because the version of pydantic required is not specified in setup.py.

Details and comments

Fixes #

@kt474 kt474 requested a review from SamFerracin June 19, 2024 15:27
Copy link
Collaborator

@SamFerracin SamFerracin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kt474 kt474 merged commit d0b361a into Qiskit:main Jun 19, 2024
18 checks passed
@kt474 kt474 deleted the update-required-pydantic-version branch June 19, 2024 15:37
@coveralls
Copy link

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9584623842

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.0%

Totals Coverage Status
Change from base Build 9584358599: 0.0%
Covered Lines: 6077
Relevant Lines: 7411

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants