This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Fix issue with parameters in metadata #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix issue with parameters in metadata * Move encode method to json_encoder. * Fix lint issue: Using type() instead of isinstance() for a typecheck * Fix lint issue: E501 line too long (115 > 100 characters) * Fix lint issue. * Rewrie the encode method * Change the parameter name. * Convert to string only for Parameter. * Test if test pass * Fix, metadata issue * Add test for Parameter in metadata * Fix lint issue in test * Fix lint issue in test * Fix lint issue in test * Move IQXJsonEncoder tests to test_serialization file * Fix lint issue in test * Fix lint issue in test Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
|
This lint issue is fixed in a following PR that I will merge to stable soon. No idea why it's failing here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backported from #1065
Details and comments