This repository was archived by the owner on Jul 28, 2023. It is now read-only.
fix python requirement versions #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
reviewed
Mar 3, 2023
| qiskit-terra>=0.18.0 | ||
| requests>=2.19 | ||
| requests_ntlm>=1.1.0 | ||
| qiskit-terra~=0.23.0 |
There was a problem hiding this comment.
This isn't valid (nor are most of the changes in this file). What this does in practice is prevents people from installing the qiskit-ibmq-provider and terra >0.23.0 together which will actively cause issues in the qiskit metapackage when terra 0.24.0 is released and will block the metapackage from being releasable.
Capping versions like this makes solving dependencies much harder and it should only be done if there are specific incompatibilities which are known.
mtreinish
added a commit
to mtreinish/qiskit-ibmq-provider
that referenced
this pull request
Mar 3, 2023
This reverts commit 2ad2352. The changes made to the requirements list in that commit were not valid and actively prevent users from installing the qiskit-ibmq-provider with any version of qiskit-terra other than the 0.23.x release series. Similarly the caps set on every dependency are overly restrictive and will cause compatibility issues with other packages, especially if there are shared dependencies between multiple packages. This commit reverts these changes to prevent issues and this needs to be released as part as 0.20.2 to unblock a future qiskit metapackage release.
kt474
added a commit
that referenced
this pull request
Mar 7, 2023
* Revert "fix python requirement versions (#1159)" This reverts commit 2ad2352. The changes made to the requirements list in that commit were not valid and actively prevent users from installing the qiskit-ibmq-provider with any version of qiskit-terra other than the 0.23.x release series. Similarly the caps set on every dependency are overly restrictive and will cause compatibility issues with other packages, especially if there are shared dependencies between multiple packages. This commit reverts these changes to prevent issues and this needs to be released as part as 0.20.2 to unblock a future qiskit metapackage release. * pin ntlm package --------- Co-authored-by: kevin-tian <kevin.tian@ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments