Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip StateTomography test until Qiskit Experiments is ready for 2.0 #55

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

eliarbel
Copy link
Contributor

@eliarbel eliarbel commented Mar 5, 2025

BackendV1 and qiskit.qobj removals in Qiskit/qiskit#13793 cause the test in qiskit_neko/tests/experiments/test_tomography.py to fail. This is part of the tests that are blocking the Qiskit/qiskit#13793 and Qiskit/qiskit#13872 PR in Qiskit from being merged.

There is a PR in Qiskit Experiments that address these removals: qiskit-community/qiskit-experiments#1526. Until it is merged, we need to skip this failing test.

Tracked in #54

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this.

Comment on lines +27 to +31
@unittest.skipIf(
tuple(map(int, qiskit.__version__.split(".")[:2])) >= (2, 0),
"Skipping test until Qiskit Experiments is ready for Qiskit 2.0. "
"Tracked in: https://github.com/Qiskit/qiskit-neko/issues/54",
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have just unconditionally skipped this but this is clever and lets us keep running things on 1.4.x and will ensure that experiments doesn't regress/break compatibility with 1.4.x when it's updated.

@mtreinish mtreinish merged commit e45e2ff into Qiskit:main Mar 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants