Remove validation methods from primitive base classes #11052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecates the argument validation methods from primitive base classes and moves them to separate helper functions. These methods unnecessarily bloat the base classes, and are odd to have when the BasePrimitive doesn't even define a run method to validate. There is no reason primitive implementations need to use the same validation as these base classes either. A follow up will be to remove the validation from the base `run` methods and have subclasses implement their own validation.
chriseclectic
requested review from
ikkoham,
t-imamichi and
a team
as code owners
|
One or more of the the following people are requested to review this:
|
chriseclectic
added
the
Changelog: Deprecation
ikkoham
reviewed
Oct 24, 2023
qiskit/primitives/base/validation.py
Outdated
| from qiskit.opflow import PauliSumOp | ||
|
|
||
|
|
||
| def validate_estimator_args( |
There was a problem hiding this comment.
If validate_estimator_args and validate_sampler_args are to be deprecated in the near future, it may not be necessary to make it public in the first place.
There was a problem hiding this comment.
I agree to make the validation functions private.
ikkoham
reviewed
Nov 1, 2023
Pull Request Test Coverage Report for Build 6716399147
💛 - Coveralls |
ikkoham
previously approved these changes
Nov 1, 2023
ikkoham
reviewed
Nov 1, 2023
ikkoham
approved these changes
Nov 1, 2023
|
@Mergifyio backport stable/0.46 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Remove validation methods from primitive base classes This deprecates the argument validation methods from primitive base classes and moves them to separate helper functions. These methods unnecessarily bloat the base classes, and are odd to have when the BasePrimitive doesn't even define a run method to validate. There is no reason primitive implementations need to use the same validation as these base classes either. A follow up will be to remove the validation from the base `run` methods and have subclasses implement their own validation. * Apply suggestions from code review * Update qiskit/primitives/base/base_estimator.py --------- Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com> (cherry picked from commit 05d958b) # Conflicts: # qiskit/primitives/base/base_sampler.py
jakelishman
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Remove validation methods from primitive base classes This deprecates the argument validation methods from primitive base classes and moves them to separate helper functions. These methods unnecessarily bloat the base classes, and are odd to have when the BasePrimitive doesn't even define a run method to validate. There is no reason primitive implementations need to use the same validation as these base classes either. A follow up will be to remove the validation from the base `run` methods and have subclasses implement their own validation. * Apply suggestions from code review * Update qiskit/primitives/base/base_estimator.py --------- Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com> (cherry picked from commit 05d958b)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
… (#11532) * Remove validation methods from primitive base classes (#11052) * Remove validation methods from primitive base classes This deprecates the argument validation methods from primitive base classes and moves them to separate helper functions. These methods unnecessarily bloat the base classes, and are odd to have when the BasePrimitive doesn't even define a run method to validate. There is no reason primitive implementations need to use the same validation as these base classes either. A follow up will be to remove the validation from the base `run` methods and have subclasses implement their own validation. * Apply suggestions from code review * Update qiskit/primitives/base/base_estimator.py --------- Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com> (cherry picked from commit 05d958b) * Update qiskit/primitives/base/base_estimator.py * Add missing import --------- Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This deprecates the argument validation methods from primitive base classes and moves them to separate helper functions. These methods unnecessarily bloat the base classes, and are odd to have when the BasePrimitive doesn't even define a run method to validate. There is no reason primitive implementations need to use the same validation as these base classes either. A follow up will be to remove the validation from the base
runmethods and have subclasses implement their own validation.Details and comments