Remove deprecated qiskit.algorithms module
#11086
Conversation
ElePT
added
Changelog: Removal
Pull Request Test Coverage Report for Build 6787737163Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
ElePT
force-pushed
the
remove-algorithms
branch
from
784080b to
6b291ab
Compare
…ove-algorithms
…erra into remove-algorithms
ElePT
requested review from
ikkoham,
t-imamichi,
a team,
alexanderivrii,
ShellyGarion and
jyu00
as code owners
|
One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Thanks for doing this, Elena. Do you know how much work is needed to fix Neko in all the relevant places before we merge this? Technically Neko isn't part of the branch protections (iirc), but it'd still be better to have all downstream projects migrated to qiskit_algorithms before we remove this.
| at the level of circuits, pulses, and algorithms. | ||
| at the level of circuits and pulses. |
There was a problem hiding this comment.
The "fix" was merged 10 mins ago Qiskit/qiskit-neko#34. I've re-triggered the CI to see if it passes now.
This reverts commit 6b291ab.
| and can be found on PyPi or `GitHub <https://github.com/qiskit-community/qiskit-algorithms>`_. | ||
| The decision to migrate the algorithms module to a separate package | ||
| was made to clarify the purpose Qiskit and make a distinction between the tools | ||
| and libraries built on top of it. |
There was a problem hiding this comment.
Not all qiskit.algorithms was migrated. Only the algorithm code that uses primitives. I think it was mentioned in prior release notes that if any of opflow/Quantum instance based algorithm function was still being used a user would first need to migrate to the primitive based algorithms. Should we briefly mention this aspect again here? Or perhaps minimally change The code has been migrated... to The primitive based algorithms from this code have been migrated... or something like that? though perhaps that's less clear if you had not been paying attention and things still worked!
|
What is the intent to deal with |
I was planning to remove the deprecated utils (validation and algorithm globals) in a follow-up PR, I don't remember the exact reason why I didn't do it all at once, but I remember trying and concluding that it would be difficult before the opflow removal. So the plan is to merge this PR, then #11111 and finally the PR deleting these utils you mentioned. These removals are targeted for |
releasenotes/notes/remove-qiskit-algorithms-a43541fe24b72208.yaml
Outdated
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
With the removal of algorithms and opflow in Qiskit#11324, Qiskit#11111, and Qiskit#11086 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.
With the removal of algorithms and opflow in Qiskit#11324, Qiskit#11111, and Qiskit#11086 along with the removal of the BIPMapping transpiler pass in Qiskit#10526 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.
With the removal of algorithms and opflow in #11324, #11111, and #11086 along with the removal of the BIPMapping transpiler pass in #10526 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.
This seems to have been missed during Qiskitgh-11086, which removed all the other test files. It hasn't been causing test-collection failures because the `test/python/algorithms/__init__.py` file was correctly removed, so this directory did not count as a package.
This seems to have been missed during gh-11086, which removed all the other test files. It hasn't been causing test-collection failures because the `test/python/algorithms/__init__.py` file was correctly removed, so this directory did not count as a package.
Summary
This PR partially addresses #10991 by removing
qiskit.algorithmsandtest.python.algorithms, updating the related sphinx references, and removing the API reference entry.Details and comments
This is PR # 2 of the "Opflow & Algorithms deprecation series", it is on hold until #11099 is merged, and blocks the opflow removal PR (#11111).