Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot State City Visualization Fixes (backport #10590) #11116

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 26, 2023

This is an automatic backport of pull request #10590 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* fix zordering and labels outside of plot

* lint and reno

* Changed reference image for state city

* correct visual of negative real value bars

* added release notes for negative real bars fix

* remove debug print statement in plot_state_city

* fix with tox eblack

* append rho to title

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>

---------

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
(cherry picked from commit 4b5546f)
@mergify mergify bot requested review from nonhermitian and a team as code owners October 26, 2023 09:01
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@github-actions github-actions bot added priority: medium Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo labels Oct 26, 2023
@github-actions github-actions bot added this to the 0.45.1 milestone Oct 26, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6651827311

  • 0 of 58 (0.0%) changed or added relevant lines in 1 file are covered.
  • 20 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.003%) to 86.898%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/state_visualization.py 0 58 0.0%
Files with Coverage Reduction New Missed Lines %
qiskit/visualization/state_visualization.py 2 59.09%
crates/qasm2/src/lex.rs 3 90.4%
qiskit/pulse/library/waveform.py 3 93.75%
crates/qasm2/src/parse.rs 12 96.67%
Totals Coverage Status
Change from base Build 6647644611: 0.003%
Covered Lines: 73850
Relevant Lines: 84985

💛 - Coveralls

@mtreinish mtreinish modified the milestones: 0.45.1, 0.45.0 Oct 30, 2023
@mtreinish mtreinish added this pull request to the merge queue Oct 30, 2023
Merged via the queue into stable/0.45 with commit 2e861ba Oct 30, 2023
@mergify mergify bot deleted the mergify/bp/stable/0.45/pr-10590 branch October 30, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo priority: medium
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants