use faster aqc objective function evaluation by default #11479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajavadia
requested review from
alexanderivrii,
ShellyGarion and
a team
as code owners
|
One or more of the the following people are requested to review this:
|
jakelishman
previously approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Given the considerations in #7697, and the obvious improvement in runtime performance with no quality regression, this seems like a sensible default switch to me.
jakelishman
added
performance
mod: transpiler
jakelishman
added
the
Changelog: New Feature
jakelishman
reviewed
Jan 2, 2024
Pull Request Test Coverage Report for Build 7393720518Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Co-authored-by: Jake Lishman <jake@binhbar.com>
jakelishman
approved these changes
Jan 3, 2024
ShellyGarion
pushed a commit
to ShellyGarion/qiskit-terra
that referenced
this pull request
Jan 18, 2024
* use faster aqc objective function evaluation by default * release note * Update qiskit/transpiler/synthesis/aqc/aqc_plugin.py Co-authored-by: Jake Lishman <jake@binhbar.com> --------- Co-authored-by: Jake Lishman <jake@binhbar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #7697 a faster objective function evaluation for AQC was introduced which is a drop-in replacement and makes convergence several times faster. However the old default was still in place. Here I switch to the faster alternative.
See the original issue about why it's worth to keep the old one around for now just in case.