Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand docstrings for annotated flag on control() and inverse() (backport #11749) #11774

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 12, 2024

This is an automatic backport of pull request #11749 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…11749)

* Add annotated

* Add returns

* Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

Apply suggestions from Matt's code review

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Format suggestions

* Fix lint

* Apply last round of suggestions

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
(cherry picked from commit 381a8d9)
@mergify mergify bot requested a review from a team as a code owner February 12, 2024 13:43
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@github-actions github-actions bot added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels Feb 12, 2024
@github-actions github-actions bot added this to the 1.0.0 milestone Feb 12, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7872655801

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.009%) to 89.216%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.81%
crates/qasm2/src/lex.rs 1 92.19%
qiskit/circuit/library/standard_gates/x.py 1 98.07%
crates/qasm2/src/parse.rs 6 97.62%
Totals Coverage Status
Change from base Build 7838300472: 0.009%
Covered Lines: 58830
Relevant Lines: 65941

💛 - Coveralls

@mtreinish mtreinish enabled auto-merge February 12, 2024 14:56
@mtreinish mtreinish added this pull request to the merge queue Feb 12, 2024
Merged via the queue into stable/1.0 with commit 2745dc1 Feb 12, 2024
14 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.0/pr-11749 branch February 12, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants