Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TwoQubitWeylDecomposition docstring #12022

Merged
merged 1 commit into from
Mar 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions qiskit/synthesis/two_qubit/two_qubit_decompose.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,9 @@ class TwoQubitWeylDecomposition:

\pi /4 \geq a \geq b \geq |c|

This is an abstract factory class that instantiates itself as specialized subclasses based on
the fidelity, such that the approximation error from specialization has an average gate fidelity
at least as high as requested. The specialized subclasses have unique canonical representations
thus avoiding problems of numerical stability.

Passing non-None fidelity to specializations is treated as an assertion, raising QiskitError if
forcing the specialization is more approximate than asserted.
This class avoids some problems of numerical instability near high-symmetry loci within the Weyl
chamber. If there is a high-symmetry gate "nearby" (in terms of the requested average gate fidelity),
then it return a canonicalized decomposition of that high-symmetry gate.

References:
1. Cross, A. W., Bishop, L. S., Sheldon, S., Nation, P. D. & Gambetta, J. M.,
Expand Down
Loading