Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Try to speed up Target python-side mapping access. #12829

Closed
wants to merge 10 commits into from
Closed

[WIP] Try to speed up Target python-side mapping access. #12829

wants to merge 10 commits into from

Conversation

raynelfss
Copy link
Contributor

Summary

Exploratory follow-up PR to #12292, attempts to speedup gate_map access in python by caching each access instance to not convert more than once.

Known issues

  • The way InstructionProperties is stored in the Target (using BaseInstructionProperties) on rust does not contain the calibration attribute. Which causes errors.

Details and comments

WIP.

raynelfss and others added 5 commits July 26, 2024 14:47
@raynelfss
Initial: Try to speed up Target rust-side mapping access.
79b59c2
@raynelfss
Merge branch 'main' into extend-target
27cf414
@raynelfss
Fix: Move calibration back to rust InstructionProperties
9d627f7 
- Accessing `Target` through rust was disabling access to the calibration attribute.
- Return Python keys object when calling `Target.keys()`
@raynelfss
Merge branch 'main' into extend-target
da3f0d2
@raynelfss
Fix: Use update_instruction_properties instead of inplace replacement.
fc37ddb 
- Use `PyRef<Self>` for `__getitem__`
- Modify `generic_backend_v2` target generation.
- Modify test in `pulse_gate_pass`.
@coveralls
Copy link

coveralls commented Aug 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10252014822

Details

  • 148 of 150 (98.67%) changed or added relevant lines in 4 files are covered.
  • 30 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.03%) to 89.785%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/accelerate/src/target_transpiler/mod.rs 80 82 97.56%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 92.48%
crates/accelerate/src/target_transpiler/mod.rs 9 84.24%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 10222290210: 0.03%
Covered Lines: 67422
Relevant Lines: 75093
💛 - Coveralls

@raynelfss raynelfss added the on hold Can not fix yet label Aug 8, 2024
@raynelfss
Copy link
Contributor Author

The efforts for this PR will be superseded by the results of #13308, in which we will hopefully address this.

@raynelfss raynelfss closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyu00 jyu00 Awaiting requested review from jyu00 jyu00 will be requested when the pull request is marked ready for review jyu00 is a code owner

Assignees
No one assigned
Labels
on hold Can not fix yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raynelfss @coveralls