Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dag_drawer Documentation to include DAGDependency on Allowed Types #13235

Merged

Conversation

azhar-ikhtiarudin
Copy link
Contributor

Summary

This PR fixes #13021 by updating the dag_drawer documentation to include DAGDependency on allowed types

Details and comments

initial:

Args:
    dag (DAGCircuit): The dag to draw.

updated:

Args:
      dag (DAGCircuit or DAGDependency): The dag to draw.

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Sep 27, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You can see in the Sphinx output that this fixes the problem

Screenshot 2024-09-30 at 4 34 30 PM

@Eric-Arellano Eric-Arellano added the documentation Something is not clear or an error documentation label Sep 30, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11074493538

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 88.848%

Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.26%
crates/qasm2/src/lex.rs 3 93.48%
qiskit/synthesis/two_qubit/xx_decompose/decomposer.py 6 90.91%
Totals Coverage Status
Change from base Build 11069637765: 0.02%
Covered Lines: 74016
Relevant Lines: 83306

💛 - Coveralls

@azhar-ikhtiarudin
Copy link
Contributor Author

Hi @nonhermitian @1ucian0 @ElePT

I hope you’re all doing well. It’s been more than three weeks since this PR has been awaiting review. All checks have passed, and it’s ready for merging once the code owner review is complete. Just a gentle reminder, and please let me know if you need any further information.

Thank you for your time and help!

@jakelishman jakelishman added this pull request to the merge queue Oct 24, 2024
Merged via the queue into Qiskit:main with commit 214e0a4 Oct 24, 2024
15 checks passed
@raynelfss raynelfss added the Changelog: None Do not include in changelog label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo documentation Something is not clear or an error documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Documentation of dag_drawer is unclear on allowed types
7 participants