Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Provider ABC (deprecated in 1.1) #13435

Merged
merged 18 commits into from
Feb 27, 2025
Merged

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Nov 13, 2024

Summary

Provider and ProviderV1 have been deprecated in #12145. This PR removes them.

@1ucian0 1ucian0 requested review from jyu00 and a team as code owners November 13, 2024 18:00
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@1ucian0 1ucian0 marked this pull request as draft November 13, 2024 19:00
@1ucian0 1ucian0 added this to the 2.0.0 milestone Nov 13, 2024
@1ucian0 1ucian0 changed the title Remove Provider ABC - deprecated in 1.1 Remove Provider ABC (deprecated in 1.1) Nov 13, 2024
@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 13573516292

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • 40 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 88.103%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/providers/basic_provider/basic_provider.py 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 94.39%
crates/qasm2/src/lex.rs 3 92.48%
crates/qasm2/src/parse.rs 18 96.68%
qiskit/visualization/circuit/_utils.py 18 94.44%
Totals Coverage Status
Change from base Build 13553732677: 0.2%
Covered Lines: 77504
Relevant Lines: 87970

💛 - Coveralls

@1ucian0
Copy link
Member Author

1ucian0 commented Nov 18, 2024

Neko failure is blocked by the release of qiskit-community/qiskit-experiments#1490

@1ucian0 1ucian0 marked this pull request as ready for review November 18, 2024 14:00
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@1ucian0 1ucian0 added the Changelog: Removal Include in the Removed section of the changelog label Dec 6, 2024
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but neko still shows that this removal breaks qiskit_experiments.

@1ucian0 1ucian0 self-assigned this Feb 6, 2025
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 2 small tweaks in the release note. but I'll just apply those and approve.

@mtreinish mtreinish enabled auto-merge February 27, 2025 18:39
@mtreinish mtreinish added this pull request to the merge queue Feb 27, 2025
Merged via the queue into Qiskit:main with commit b89dd7f Feb 27, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants