Migrate CI to Github Actions #13474
Open
Migrate CI to Github Actions #13474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raynelfss
added
the
type: qa
raynelfss
force-pushed
the
move-to-gh
branch
from
19bce30 to
fb398bb
Compare
Pull Request Test Coverage Report for Build 12967397921Details
💛 - Coveralls |
raynelfss
force-pushed
the
move-to-gh
branch
2 times, most recently
from
74a0fe4 to
ba1a164
Compare
raynelfss
force-pushed
the
move-to-gh
branch
2 times, most recently
from
ebc3e6e to
e0c9a46
Compare
|
I have yet to test the nightly, merge-queue, and push tests. But I believe they should work without issues since they're mostly reusing the same workflows we use here for Pull Requests CI. I'm going to open this up for review :) |
|
One or more of the following people are relevant to this code:
|
- Added `depth: 0` to checkout to avoid reno bugs.
- Rename `tests-linux.yml` to `test-linux.yml`.
- Add comments - Rename `Qiskit CI workflow` to `Pull Request`
- Add missing `.yml` extension in reusable workflow references.
- For testing purposes.
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Jan 26, 2025
With native linux aarch64 runners available from github now available [1] we can run tests on every PR on the platform and promote it to tier 1 support [2]. This commit adds a github action test job that runs on PRs to test that the platform works on every commit. Then the wheel job is promoted to the tier 1 job which includes PGO which will improve the performance on the wheels we publish for the platform. While there is a larger effort to migrate our entire CI to github actions in Qiskit#13474 expanding our test matrix prior to that won't cause a conflict as we can easily expand the test matrix in that PR if this merges first. [1]: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/ [2]: https://docs.quantum.ibm.com/guides/install-qiskit#operating-system-support
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Jan 26, 2025
With native linux aarch64 runners available from github now available [1] we can run tests on every PR on the platform and promote it to tier 1 support [2]. This commit adds a github action test job that runs on PRs to test that the platform works on every commit. Then the wheel job is promoted to the tier 1 job which includes PGO which will improve the performance on the wheels we publish for the platform. While there is a larger effort to migrate our entire CI to github actions in Qiskit#13474 expanding our test matrix prior to that won't cause a conflict as we can easily expand the test matrix in that PR if this merges first. [1]: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/ [2]: https://docs.quantum.ibm.com/guides/install-qiskit#operating-system-support
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
* Promote linux aarch64 to tier 1 support With native linux aarch64 runners available from github now available [1] we can run tests on every PR on the platform and promote it to tier 1 support [2]. This commit adds a github action test job that runs on PRs to test that the platform works on every commit. Then the wheel job is promoted to the tier 1 job which includes PGO which will improve the performance on the wheels we publish for the platform. While there is a larger effort to migrate our entire CI to github actions in #13474 expanding our test matrix prior to that won't cause a conflict as we can easily expand the test matrix in that PR if this merges first. [1]: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/ [2]: https://docs.quantum.ibm.com/guides/install-qiskit#operating-system-support * Update job name for test job * Try latest manylinux image for arm * Use url for image path * Try without explicit latest tag * Tweak rust install script * Revert "Try without explicit latest tag" This reverts commit d39b6ee. * Split out aarch64 tier 1 job to separate job The aarch64 wheel builds are failing with PGO on latest stable (and stable - 1). This is likely either an issue in rustc or the llvm tools component from rustup on the later releases. But it seems to build fine with our MSRV. We build with latest stable for release jobs typically to enable the improvements from the latest compiler for what we publish. But PGO has enough benefit that using our MSRV is fine if that is what's necessary. * Remove duplicate tier 1 arm job * Try different target string to fix profile version mismatch * Tweak msrv install again * Only install a single rust toolchain in aarch64 env * Deduplicate job definitions * Add comment about msrv location * Remove stale comment * Fix release notes typo * Adjust run script * Set rust toolchain to msrv in build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12807.
The following commits move existing workflows from Azure into Github Actions.
Details and comments
As simple as it may seem, our CI Pipeline goes through several workflows, some of which are split between Github Actions and Azure Workflows. While Azure Workflows provided us with many extra features and an isolated quota, tests seem to run much slower than they would with Github Actions (exact numbers to be examined). This move will (most likely) ensure that workflows run faster increasing our overall commit throughput.
The moved workflows include:
New Pull Request workflow
The new PR workflow looks as such:
Where if both
Docs and LintandPreliminary Testspass, then the rest of the test suite runs concurrently.Tasks
Known issues