Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method to convert BitArray into boolean array #13653

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

amiigas
Copy link
Contributor

@amiigas amiigas commented Jan 12, 2025

Summary

implements: #13396

Details and comments

  • added a method to convert a BitArray to a NumPy boolean array
  • added corresponding tests

@amiigas amiigas requested review from a team as code owners January 12, 2025 21:53
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jan 12, 2025
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @ajavadia
  • @levbishop
  • @t-imamichi

Copy link
Contributor

@ihincks ihincks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The implementation and tests look good to me. Two very minor comments on the docstring.

@ihincks ihincks added the Changelog: New Feature Include in the "Added" section of the changelog label Jan 19, 2025
@ihincks
Copy link
Contributor

ihincks commented Jan 20, 2025

Oh, this PR also needs a reno, please see CONTRIBUTING.md for instructions (or let me know and I can push one). It only needs to be a sentence or two in this case.

@ihincks ihincks enabled auto-merge January 20, 2025 21:07
@t-imamichi t-imamichi added the mod: primitives Related to the Primitives module label Jan 21, 2025
@ihincks ihincks added this pull request to the merge queue Jan 21, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12875631142

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 362 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.02%) to 88.934%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/remove_identity_equiv.rs 1 95.45%
crates/accelerate/src/barrier_before_final_measurement.rs 1 98.65%
crates/accelerate/src/check_map.rs 1 98.39%
crates/qasm2/src/lex.rs 4 91.48%
qiskit/qasm3/exporter.py 5 96.2%
crates/accelerate/src/inverse_cancellation.rs 5 95.83%
crates/accelerate/src/gate_direction.rs 8 97.58%
crates/accelerate/src/target_transpiler/mod.rs 12 82.95%
crates/qasm2/src/parse.rs 12 96.69%
crates/accelerate/src/commutation_checker.rs 16 97.46%
Totals Coverage Status
Change from base Build 12710188694: 0.02%
Covered Lines: 79427
Relevant Lines: 89310

💛 - Coveralls

Merged via the queue into Qiskit:main with commit 400f22d Jan 21, 2025
17 checks passed
emilkovacev pushed a commit to emilkovacev/qiskit that referenced this pull request Feb 7, 2025
* feat: add method to convert `BitArray` into boolean array

* docs: minor changes in docstrings

* docs: add release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo mod: primitives Related to the Primitives module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants