Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated stochastic swap transpiler pass #13791

Merged
merged 11 commits into from
Feb 25, 2025

Conversation

mtreinish
Copy link
Member

Summary

This commit removes the stochastic swap transpiler pass and its associated routing stage plugin. This pass has been superseded by sabre at this point and it was deprecated in the Qiskit 1.3.0 release.

Details and comments

Part of #13699

This commit removes the stochastic swap transpiler pass and its
associated routing stage plugin. This pass has been superseded by sabre
at this point and it was deprecated in the Qiskit 1.3.0 release.

Part of Qiskit#13699
@mtreinish mtreinish requested a review from a team as a code owner February 5, 2025 17:57
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@mtreinish mtreinish added the Changelog: Removal Include in the Removed section of the changelog label Feb 5, 2025
@mtreinish mtreinish added this to the 2.0.0 milestone Feb 5, 2025
@mtreinish mtreinish added the mod: transpiler Issues and PRs related to Transpiler label Feb 5, 2025
@coveralls
Copy link

coveralls commented Feb 5, 2025

Pull Request Test Coverage Report for Build 13511266405

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.02%) to 87.973%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 94.39%
qiskit/transpiler/passes/layout/dense_layout.py 1 95.12%
qiskit/transpiler/preset_passmanagers/builtin_plugins.py 1 95.5%
crates/qasm2/src/lex.rs 3 92.48%
crates/circuit/src/dag_circuit.rs 9 86.13%
qiskit/transpiler/passes/routing/utils.py 10 0.0%
Totals Coverage Status
Change from base Build 13508932591: -0.02%
Covered Lines: 77502
Relevant Lines: 88097

💛 - Coveralls

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o7 to the first Rust code of Qiskit

Co-authored-by: Jake Lishman <jake@binhbar.com>
@jakelishman
Copy link
Member

Oh also I meant to write in the top review comment: we need to update the qiskit.transpiler and qiskit.transpiler.preset_passmanager.plugin docstrings to remove the reference to the stochastic plugin.

@jakelishman
Copy link
Member

There's also a couple of places in the benchmark suite that refer to the stochastic plugin.

@1ucian0 1ucian0 self-assigned this Feb 20, 2025
@1ucian0 1ucian0 self-requested a review February 24, 2025 14:57
@mtreinish
Copy link
Member Author

There's also a couple of places in the benchmark suite that refer to the stochastic plugin.

Fixed in: b057980

Oh also I meant to write in the top review comment: we need to update the qiskit.transpiler and qiskit.transpiler.preset_passmanager.plugin docstrings to remove the reference to the stochastic plugin.

Fixed in cdf7826

I opted to keep the reference I found in plugin.py because it looked like the only mention there was that "stochastic" was marking it as a reserved which seems fine to keep just so people don't have issues if they want to develop a plugin that supports 1.x and 2.x.

jakelishman
jakelishman previously approved these changes Feb 24, 2025
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can live with leaving stochastic in the "reserved names" list, though it wouldn't surprise me if there's a PR in 6 months' time deleting it, confused about why we're reserving something we don't use haha.

@jakelishman
Copy link
Member

jakelishman commented Feb 24, 2025

Oh, a lint complaint about import warnings in test/python/transpiler/test_mappers.py.

@jakelishman jakelishman added this pull request to the merge queue Feb 25, 2025
Merged via the queue into Qiskit:main with commit 682e2d3 Feb 25, 2025
19 checks passed
@mtreinish mtreinish deleted the farewell-old-friend branch February 25, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog mod: transpiler Issues and PRs related to Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants