-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated stochastic swap transpiler pass #13791
Conversation
This commit removes the stochastic swap transpiler pass and its associated routing stage plugin. This pass has been superseded by sabre at this point and it was deprecated in the Qiskit 1.3.0 release. Part of Qiskit#13699
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13511266405Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o7 to the first Rust code of Qiskit
releasenotes/notes/remove-stochastic-swap-88e2d6be4c0d5713.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/remove-stochastic-swap-88e2d6be4c0d5713.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Jake Lishman <jake@binhbar.com>
Oh also I meant to write in the top review comment: we need to update the |
There's also a couple of places in the benchmark suite that refer to the |
Fixed in: b057980
Fixed in cdf7826 I opted to keep the reference I found in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can live with leaving stochastic
in the "reserved names" list, though it wouldn't surprise me if there's a PR in 6 months' time deleting it, confused about why we're reserving something we don't use haha.
Oh, a lint complaint about |
Summary
This commit removes the stochastic swap transpiler pass and its associated routing stage plugin. This pass has been superseded by sabre at this point and it was deprecated in the Qiskit 1.3.0 release.
Details and comments
Part of #13699