Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pulse from GenericBackendV2 #13829

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

eliarbel
Copy link
Contributor

This commit removes pulse-related functionality from GenericBackendV2, as part of Pulse removal in Qiskit 2.0. This includes the ability to initialize the backend with custom calibrations and query it for channel information. Also, various clean ups where made to accommodate for the updated API of GenericBackendV2.

Part of #13662

This commit removes pulse-related functionality from GenericBackendV2, as
part of Pulse removal in Qiskit 2.0. This includes the ability to initialize
the backend with custom calibrations and query it for channel information.
Also, various clean ups where made to accommodate for the updated API of
GenericBackendV2.
@eliarbel eliarbel added Changelog: Removal Include in the Removed section of the changelog mod: fake_provider Related to the fake_provider module and fake backends labels Feb 12, 2025
@eliarbel eliarbel added this to the 2.0.0 milestone Feb 12, 2025
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @ajavadia
  • @levbishop
  • @nkanazawa1989
  • @t-imamichi

ElePT
ElePT previously approved these changes Feb 12, 2025
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just left a minor suggestion in the reno.

…b8fd.yaml

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13288941762

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 477 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.07%) to 88.249%

Files with Coverage Reduction New Missed Lines %
qiskit/pulse/calibration_entries.py 1 90.57%
qiskit/pulse/instructions/instruction.py 1 94.57%
qiskit/providers/fake_provider/generic_backend_v2.py 1 96.67%
crates/accelerate/src/unitary_synthesis.rs 2 93.4%
crates/accelerate/src/split_2q_unitaries.rs 2 97.01%
crates/qasm2/src/lex.rs 3 92.73%
crates/accelerate/src/circuit_library/quantum_volume.rs 4 96.04%
crates/qasm2/src/parse.rs 6 97.61%
qiskit/pulse/instruction_schedule_map.py 8 89.34%
crates/accelerate/src/consolidate_blocks.rs 13 94.59%
Totals Coverage Status
Change from base Build 13271264264: -0.07%
Covered Lines: 78551
Relevant Lines: 89011

💛 - Coveralls

@ElePT
Copy link
Contributor

ElePT commented Feb 13, 2025

Sorry for the conflict, I hope it's not too painful to address.

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am aware that the broken coverage tests are due to external causes, so I would move ahead with this PR regardless of the state of those tests.

@ElePT ElePT added this pull request to the merge queue Feb 13, 2025
Merged via the queue into Qiskit:main with commit 6550884 Feb 13, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog mod: fake_provider Related to the fake_provider module and fake backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants