Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect stop time bug #8729 (backport #11097) #13843

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 13, 2025

  • I have added the tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Summary

This pull request addresses the incorrect stop time bug related in #8729. I have also added tests to ensure this change doesn't break again.

Fixes #8729.


This is an automatic backport of pull request #11097 done by [Mergify](https://mergify.com).

* Fix incorrect stop time bug #8729

* Apply suggestions from code review

Minor update on the release note

* Update qiskit/circuit/quantumcircuit.py

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>

* Update releasenotes/notes/fix-incorrect-qubit-stop-time-d0e056f60a01dd52.yaml

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>

---------

Co-authored-by: Toshinari Itoko <15028342+itoko@users.noreply.github.com>
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
(cherry picked from commit 6842268)
@mergify mergify bot requested a review from a team as a code owner February 13, 2025 23:02
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo labels Feb 13, 2025
@github-actions github-actions bot added this to the 1.3.3 milestone Feb 13, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13318735185

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.005%) to 88.915%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/circuit/quantumcircuit.py 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 93.21%
crates/qasm2/src/lex.rs 4 92.23%
Totals Coverage Status
Change from base Build 13315768260: 0.005%
Covered Lines: 79171
Relevant Lines: 89041

💛 - Coveralls

@ShellyGarion ShellyGarion added this pull request to the merge queue Feb 14, 2025
Merged via the queue into stable/1.3 with commit acc9cec Feb 14, 2025
20 checks passed
@mtreinish mtreinish deleted the mergify/bp/stable/1.3/pr-11097 branch February 19, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants