Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin symengine in backwards compatibility tests #13885

Merged
merged 4 commits into from
Feb 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ python-dateutil>=2.8.0
stevedore>=3.0.0
typing-extensions

# If updating the version range here, consider updating 'test/qpy_compat/run_tests.sh' to update the
# list of symengine dependencies used in the cross-version tests.
# If updating the version range here, consider updating the
# list of symengine dependencies used in the cross-version tests
# in 'test/qpy_compat/run_tests.sh' and 'test/qpy_compat/qpy_test_constraints.txt'
symengine>=0.11,<0.14
5 changes: 5 additions & 0 deletions test/qpy_compat/qpy_test_constraints.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
numpy===1.24.4
scipy===1.10.1

# This is a loose constraint because we want to test different versions,
# as defined in 'test/qpy_compat/run_tests.sh', but any symengine version
# above (and including) 0.14 will be incompatible with qpy.
symengine<0.14
2 changes: 2 additions & 0 deletions test/qpy_compat/run_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ popd
# This will likely duplicate the base dev-compatibility test, but the tests are fairly fast, and
# it's better safe than sorry with the serialisation tests.

# Note that the constraint in the range of symengine versions is logically duplicated
# in `qpy_test_constraints.txt`
symengine_versions=(
'>=0.11,<0.12'
'>=0.13,<0.14'
Expand Down