-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 1.4.0 release #13898
Prepare 1.4.0 release #13898
Conversation
releasenotes/notes/1.4/Fixed-param-gate-target-has-and-get_calibration-d2b9e38d63592b3c.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.4/deprecate-DAGNode-sort-key-3c6ed71133875872.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.4/deprecate-DAGNode-sort-key-3c6ed71133875872.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.4/deprecate-pulse-leftovers-b00c70f828d1a7fa.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.4/deprecate-pulse-leftovers-b00c70f828d1a7fa.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.4/deprecate-pulse-leftovers-b00c70f828d1a7fa.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.4/deprecate-run-experiment-f37b3f35724bc6bb.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.4/deprecate-subclass-register-0ee4ab0b71c4bb4f.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: abbycross <across@us.ibm.com>
1.3.x to 1.4.0 so that you're able to see the warnings about which | ||
interfaces will change with Qiskit 2.0.0. | ||
The 1.4.x release series will continue to be supported and recieve | ||
bugfix and security fixes via patch releases for 6 months after this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were planning to have 6 months for general bugfixes and 1 yr for security fixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, forgot about the specific timelines. Thanks for catching that.
…g and tags to determine the grouping of the release notes temporally. Because 1.4 has been around in parallel to 1.3, this causes the automatic grouping to show 1.4 release notes under 1.3.
One or more of the following people are relevant to this code:
|
The PR is on hold until #13868 is merged. I will add the ci-buildwheels label then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM, just a few small inline comments and questions. I did check and all the version strings look like they're correctly on 1.4.0 (which apparently I did back in December, but don't remember doing: #13525)
.. code-block:: python | ||
|
||
from qiskit import QuantumRegister, QuantumCircuit | ||
from qiskit.circuit.library.phase_oracle import PhaseOracle | ||
|
||
bool_expr = "(x0 & x1 | ~x2) & x4" | ||
qr_x = QuantumRegister(4, "x") | ||
qr_y = QuantumRegister(1, "y") | ||
|
||
bit_flip_oracle = QuantumCircuit(qr_x, qr_y) | ||
phase_flip_oracle = PhaseOracle(bool_expr) | ||
controlled_phase_flip_oracle = phase_flip_oracle.control(1) | ||
bit_flip_oracle.h(qr_y) | ||
bit_flip_oracle.compose(controlled_phase_flip_oracle, qubits=[*qr_y, *qr_x], inplace=True) | ||
bit_flip_oracle.h(qr_y) | ||
|
||
print(bit_flip_oracle) | ||
|
||
Which results in | ||
|
||
.. code-block:: text | ||
|
||
┌───────────────┐ | ||
x_0: ─────┤0 ├───── | ||
│ │ | ||
x_1: ─────┤1 ├───── | ||
│ Phase Oracle │ | ||
x_2: ─────┤2 ├───── | ||
│ │ | ||
x_3: ─────┤3 ├───── | ||
┌───┐└───────┬───────┘┌───┐ | ||
y: ┤ H ├────────■────────┤ H ├ | ||
└───┘ └───┘ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use the plot directive for this instead. and get a graphical visualization. But it's not critical.
of instructions. From Qiskit v2.0.0 on, ``target`` will be required and | ||
:func:`~qiskit.visualization.timeline.interface.draw` will fail if it is not specified. | ||
|
||
upgrade_transpiler: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an upgrade note? It feels like a deprecation category might be more appropriate or just other note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a bit in the middle. Other seems fine.
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Summary
This PR is more minimal than the usual release preparation PRs because the 1.4 branch was created in advance and already had the correct version number in most places. An additional change is that this minor will not have an
rc1
, it will be released directly.Details and comments
The 1.4 renos have been manually placed into a single file.
reno
uses the git log and tags to determine the grouping of the release notes temporally. Because 1.4 has been around in parallel to 1.3, this causes the automatic grouping to show 1.4 release notes under 1.3.