Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation about instruction duration (backport #13592) #13900

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 21, 2025

Summary

The deprecations introduced in #13247 did not notify via docs.


This is an automatic backport of pull request #13592 done by Mergify.

* add docuemntation about instruction duration

* more docs and some spelling

* Apply suggestions from code review

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>

* Update qiskit/circuit/instruction.py

* Fix black

* Fix lint

---------

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Co-authored-by: Elena Peña Tapia <epenatap@gmail.com>
(cherry picked from commit 83c20e9)
@mergify mergify bot requested review from nonhermitian, a team, eggerdj and wshanks as code owners February 21, 2025 09:23
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

@github-actions github-actions bot added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels Feb 21, 2025
@github-actions github-actions bot added this to the 1.4.0 milestone Feb 21, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13453804042

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 88.868%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 93.48%
Totals Coverage Status
Change from base Build 13447972432: 0.007%
Covered Lines: 79401
Relevant Lines: 89347

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Feb 21, 2025
Merged via the queue into stable/1.4 with commit f0d26e5 Feb 21, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants