Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing inverse definitions in generate_basis_approximations (backport #13517) #13964

Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix missing inverse definitions in generate_basis_approximations (backport #13517) #13964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions qiskit/synthesis/discrete_basis/generate_basis_approximations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
"tdg": "t",
"s": "sdg",
"sdg": "s",
"sx": "sxdg",
"sxdg": "sx",
}

_1q_gates = {
Expand Down
6 changes: 6 additions & 0 deletions releasenotes/notes/fix-missing-inverse-definition-af7fe8d9f2193308.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
fixes:
- |
Fixed a bug in the basis approximation generation for :class:`.SolovayKitaev`.
Previously, generating discrete basis approximations using
``generate_basis_approximations`` for a basis containing ``"sx"`` or
``"sxdg"`` gates would fail. This has now been fixed.
2 changes: 1 addition & 1 deletion test/python/transpiler/test_solovay_kitaev.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ def test_generate_basis_approximation_gates(self):

Regression test of Qiskit/qiskit-terra#9585.
"""
basis = ["i", "x", "y", "z", "h", "t", "tdg", "s", "sdg"]
basis = ["i", "x", "y", "z", "h", "t", "tdg", "s", "sdg", "sx", "sxdg"]
approx = generate_basic_approximations(basis, depth=2)

# This mainly checks that there are no errors in the generation (like
Expand Down