Attempt to fix MacOS PGO build #13992
Open
+11
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Link Python library manually in the PGO build, which works out locally. This is done inside
build_pgo.sh
instead of thewheels-build.yml
to ensure the correct Python library is found. This is more of a backup solution, it would be nicer if PyO3/Rust would be able to link the required libraries automatically (maybe we're missing some flag).Details and comments
Possibly this needs an additional
DYLD_LIBRARY_PATH
export, but let's see what the wheels say...