Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix MacOS PGO build #13992

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Mar 11, 2025

Summary

Link Python library manually in the PGO build, which works out locally. This is done inside build_pgo.sh instead of the wheels-build.yml to ensure the correct Python library is found. This is more of a backup solution, it would be nicer if PyO3/Rust would be able to link the required libraries automatically (maybe we're missing some flag).

Details and comments

Possibly this needs an additional DYLD_LIBRARY_PATH export, but let's see what the wheels say...

@Cryoris Cryoris added the ci: test wheels Run the wheel-build scripts as an additional CI run for this PR label Mar 11, 2025
@Cryoris Cryoris requested a review from a team as a code owner March 11, 2025 13:35
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@ElePT
Copy link
Contributor

ElePT commented Mar 11, 2025

May the wheels be with you

@coveralls
Copy link

coveralls commented Mar 11, 2025

Pull Request Test Coverage Report for Build 13793277941

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.009%) to 88.139%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 94.69%
crates/qasm2/src/lex.rs 3 92.48%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 13792557824: 0.009%
Covered Lines: 72643
Relevant Lines: 82419

💛 - Coveralls

@Cryoris
Copy link
Contributor Author

Cryoris commented Mar 11, 2025

They were not (quite)... the build_pgo.sh script now runs successfully but it's still not finding the libraries in the final build of the optimized binary.

@Cryoris
Copy link
Contributor Author

Cryoris commented Mar 11, 2025

As side note: changing the libtype of qiskit-cext from cdylib to staticlib works without requiring any library setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: test wheels Run the wheel-build scripts as an additional CI run for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants