Add missing __getitem__ and other attributes to BitLocations (backport #13997)
#14008
+75
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
) * Add: `__getitem__` and other attributes to `BitLocations` In an oversight after #13860, when switching to use the pyo3 friendly `BitLocations` which is not an instance of `namedtuple` we did not extend it to include sequence methods `__getitem__` and `__len__`, which results in breaking api changes. The following commits add those methods to `BitLocations` and also labels the class correctly as a `sequence` in PyO3. * Fix: Address review comments * Fix: More formatting issues in tests * Apply suggestions from code review Co-authored-by: Matthew Treinish <mtreinish@kortar.org> --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 3a80a81)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
bug
mtreinish
approved these changes
Mar 12, 2025
Pull Request Test Coverage Report for Build 13819580940Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13996
Summary
We accidentaly removed the capability of indexing a
BitLocationobject. These commits add that functionality back!Details and comments
In an oversight after #13860, when switching to use the pyo3 friendly
BitLocationswhich is not an instance ofnamedtuplewe did not extend it to include sequence methods__getitem__and__len__, which results in breaking api changes.The following commits add those methods to
BitLocationsand also labels the class correctly as asequencein PyO3.This is an automatic backport of pull request #13997 done by [Mergify](https://mergify.com).