Swapped out use of sincos() for more portability across platforms #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sincos()
is a GNU extension provided by glibc. With Xcode 15.1 on Apple Silicon, we get the following error:We can, technically, use preprocessor directives to get around this; for example:
However, I feel that's not really elegant. To improve portability across platforms, we should switch to invoking

sin()
andcos()
separately. Yes, this will be theoretically slower -- BUT many good compilers can detect this situation and perform optimization as necessary: