Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review simulation presets #105

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Review simulation presets #105

merged 3 commits into from
Sep 14, 2023

Conversation

mca-sh
Copy link
Collaborator

@mca-sh mca-sh commented Sep 13, 2023

Fixes #104

  • Transition rate matrix having non-null diagonal terms and imported from preset files were yielding incorrect state lifetimes used in the generation of state sequences. It is now handles correctly by setting all diagonal term of the matrix to 0 before using it.
  • the field nametrans_prob used in preset files was misleading as it intuitively refers to transition probability matrix, what they are not, instead of transition partition probabilities, which they are. It is now replaced by field trans_part.
  • State lifetimes could not be imported in preset files. They can now be imported together with the partition probability matrix using the field lifetimes in preset files.

…mes and handle non-null diagonal terms in preset rate matrices
@mca-sh mca-sh added bugfix Bugs were fixed improvement Improve existing functionalities, scripts or workflow labels Sep 13, 2023
@mca-sh mca-sh merged commit e8881a5 into master Sep 14, 2023
@mca-sh mca-sh deleted the review-sim-presets branch November 28, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugs were fixed improvement Improve existing functionalities, scripts or workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simulation pre-set file not read properly
1 participant