Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coloring common IMU functions and change default max bulk param in dynamixel workbench to 21 #255

Merged
merged 4 commits into from
Jan 15, 2021

Conversation

tzf230201
Copy link
Contributor

recently I worked with build-in IMU on the openCR board,
coloring some common functions will be very helpful during the debugging process

@tzf230201 tzf230201 changed the title coloring common functions coloring common IMU functions Oct 22, 2020
@tzf230201
Copy link
Contributor Author

I changed the max bulk parameter from 20 to 21 because most humanoid kid-size (20 dof) robot projects in the world use openCR as their sub-controller, like me too.

for some reason, I shouldn't change my dynamixel protocol from 1.0 to 2.0, so couldn't use the sync read function, and was forced to use bulk read instead.

because the maximum parameter in the addBulkReadParam function is limited by

if (bulk_read_parameter_cnt_ <(MAX_BULK_PARAMETER-1))

then only 19 servos can take advantage of this bulk read.

I think changing the maximum bulk parameter from 20 to 21 will be of great help to people on humanoid projects.

then I also found a typo in the error message as well as the bulk param that was added exceeding the limit.

previously written "Too many bulk parameter are added (default buffer size is 10)"

even though the dynamixel_driver.h file sets the default buffer size to 20

#define MAX_BULK_PARAMETER 20

because I changed the max bulk param to 21, so I changed the error message to
"Too many bulk parameters are added (default buffer size is 21)".

@tzf230201 tzf230201 changed the title coloring common IMU functions coloring common IMU functions and change default max bulk param in dynamixel workbench to 21 Oct 28, 2020
@ROBOTIS-Will
Copy link
Contributor

Hi @tzf230201 Thank you for your contribution :)
We'll review your PR and merge it. This may take a couple weeks.
Thank you!

@ROBOTIS-Will ROBOTIS-Will self-requested a review October 29, 2020 00:59
@ROBOTIS-Will ROBOTIS-Will added the enhancement New feature or request label Oct 29, 2020
@ROBOTIS-Will ROBOTIS-Will merged commit 0d26c46 into ROBOTIS-GIT:develop Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants