Add cmake option AOTRITON_NAME_SUFFIX to resolve name conflicts #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with ``` cmake .. -DCMAKE_INSTALL_PREFIX=./install_dir -DCMAKE_BUILD_TYPE=Release -DAOTRITON_GPU_BUILD_TIMEOUT=0 -G Ninja -DTARGET_GPUS=MI200 -DAOTRITON_NAME_SUFFIX="123"; ```
xinyazhang
requested review from
jeffdaily,
wangye805,
pruthvistony,
jithunnair-amd and
jayfurmanek
Otherwise pyaotriton may call the libaotriton_v2.so shipped with PyTorch and cause weird bugs.
| #if AOTRITON_ENABLE_SUFFIX | ||
| #define xstr(s) str(s) | ||
| #define str(s) #s | ||
| []() -> std::string { return xstr(AOTRITON_NAME_SUFFIX); } |
There was a problem hiding this comment.
@xinyazhang I'm sure there's some nuance with the preprocessing flow here, but can you elaborate why we need two macros xstr and str?
There was a problem hiding this comment.
| # target_link_libraries(aotriton INTERFACE ${AOTRITON_V2_BUILD_DIR}/${AOTRITON_LIBRARY_FILE}) | ||
| # target_include_directories(aotriton INTERFACE ${CMAKE_CURRENT_SOURCE_PARENT_DIR}/include) | ||
| # target_include_directories(aotriton INTERFACE ${CMAKE_CURRENT_SOURCE_PARENT_DIR}/include) | ||
| target_link_libraries(aotriton INTERFACE aotriton_v2) |
There was a problem hiding this comment.
@xinyazhang Are these changes related to the name suffix feature? Can you please explain this changeset?
There was a problem hiding this comment.
the suffix is not long added to the symbols, but also added to the output files. Linking aotriton INTERFACE can eliminate the necessary to construct the output file name with suffix again.
This forces find_package(Python3) select Python >= 3.8 by default. User may override this to pick a higher version of Python.
|
Build was successful and produced following outputs: |
jithunnair-amd
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds suffix to namespace
aotritonand the library file prefixlibaotriton. For example, build with-DAOTRITON_NAME_SUFFIX=123will generate the library withnamespace aotrition123andlibaotriton123_v2.so.This is to address potential name conflicts with PyTorch since PyTorch will bundle AOTriton shared library starting 2.4+